This repository has been archived by the owner on Jan 23, 2021. It is now read-only.
Friendlier error messages for two types of bad parameters. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a nice improvement to the current error logging. Deferring to @gauntface as he may have more detailed feedback. |
Closed
|
LGTM Time for le merge. |
jeffposnick
added a commit
that referenced
this pull request
Nov 2, 2015
Friendlier error messages for two types of bad parameters.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @gauntface @addyosmani
This addresses two specific points that @gauntface raised in #43
We are obviously a long way from proactively checking for every permutation of bad parameters and displaying a custom error response for each, vs. relying on the default exception handling to pick up and log (sometimes generic) failures. @gauntface, if you have an example of a JS library that you feel does this well right now—proactively checks for every permutation of bad parameters and displays a bespoke message for each—then I'd appreciate it if you could point me to it and I'll try to follow a similar approach.
The documentation improvements that @jpmedley is looking into can also help prevent developers from providing unexpected parameters to begin with.