-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove novalidate attribute from comment form to enable client-side validation #717
Conversation
…from comments form
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Codecov Report
@@ Coverage Diff @@
## develop #717 +/- ##
=============================================
- Coverage 19.96% 19.93% -0.03%
Complexity 326 326
=============================================
Files 56 56
Lines 2094 2097 +3
=============================================
Hits 418 418
- Misses 1676 1679 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
If offline commenting is removed as suggested in #363 (comment), then this wouldn't be strictly necessary. I'm not totally settled on the direction of that, but I'm leaning towards removal of the feature. |
Co-authored-by: Weston Ruter <[email protected]>
Yes, I also agree with your point for the removal of offline commenting, but until it is completely removed we can add this feature and also remove it along with the offline commenting feature. |
That's the thing. I think we may just remove it entirely because (1) it's broken when a user tries to comment while logged-in and their nonce expires, and (2) I don't believe anyone is using it (at least I've never heard of someone talking about this feature). |
@westonruter Since we are removing the offline-commenting feature in #728, should we close this PR? |
Yes, thanks. |
Fixes: #364
This PR adds an action to remove the
novalidate
attribute which is added by WordPress core in the comments form. Removing that attribute will enable client-side validation too for comment form which may not allow invalid data to be submitted.Screenshot