Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline commenting can fail if the user does not provide valid fields #364

Closed
westonruter opened this issue Dec 12, 2020 · 3 comments
Closed

Comments

@westonruter
Copy link
Collaborator

The comment form has a novalidate attribute to force server-side validation of the fields. This is done to bypass HTML5 client-side form validation, since it used to be that the validation was not reliable across browsers. Even so, novalidate remains. So at the moment someone could enter a comment but then leave the Name or Email empty, and submit the comment while offline. Once the user is back online, background sync will try to submit the comment but it will be rejected by WordPress due to not having a name or email.

So the PWA plugin should remove the novalidate attribute from the comment form as I suggested in TRAC-47595.

@westonruter
Copy link
Collaborator Author

This may be obsolete (or punted) if offline commenting is removed per #363 (comment).

@westonruter
Copy link
Collaborator Author

Obsolete since offline commenting has been removed in #728.

@westonruter westonruter removed this from the 0.7 milestone Apr 15, 2022
@pooja-muchandikar
Copy link

pooja-muchandikar commented Apr 21, 2022

As per #364 (comment) this feature is entirely removed from the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants