Only unauthenticate user when parse_query is for the main query
#712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #712 +/- ##
==========================================
Coverage 19.96% 19.96%
Complexity 326 326
==========================================
Files 56 56
Lines 2094 2094
==========================================
Hits 418 418
Misses 1676 1676
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
thelovekesh
reviewed
Apr 15, 2022
| @@ -75,4 +75,24 @@ public function test_wp_unauthenticate_error_template_requests( $request_url, $a | |||
| $this->assertEquals( 0, get_current_user_id() ); | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Test that that `wp_unauthenticate_error_template_requests()` running at the `parse_query` action doesn't cause | |||
There was a problem hiding this comment.
Suggested change
| * Test that that `wp_unauthenticate_error_template_requests()` running at the `parse_query` action doesn't cause | |
| * Test that `wp_unauthenticate_error_template_requests()` running at the `parse_query` action doesn't cause |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #279 and it addresses a conflict with Polylang identified in a support topic.
The issue is that if a
WP_Queryinstance is created before the main query, then this can result in ourwp_unauthenticate_error_template_requests()running on theparse_queryaction when there is no$wp_queryglobal yet set. The result is a notice:The fix is simply to ensure that the query being parsed is the main query, because that will ensure that the
$wp_the_queryhas been set, at which point the$wp_queryglobal has already been set.Fixes #538.