PHP Notice: is_offline was called incorrectly

[Youdaman]

Couple of intermittent errors/notices in debug.log:

PHP Notice: is_offline was called incorrectly. Conditional query tags do not work before the query is run. Before then, they always return false. Please see Debugging in WordPress for more information.

PHP Notice: is_500 was called incorrectly. Conditional query tags do not work before the query is run. Before then, they always return false. Please see Debugging in WordPress for more information.

Line 98 of wp-content\plugins\pwa\wp-includes\general-template.php seems to be the problem?

/**
 * Add no-robots meta tag to error template.
 *
 * @todo Is this right? Should we add_action when we find out that the filter is present?
 * @see wp_no_robots()
 * @since 0.2
 */
function wp_add_error_template_no_robots() {
	if ( is_offline() || is_500() ) {
		wp_no_robots();
	}
}

[westonruter]

The wp_add_error_template_no_robots() function runs at wp_head and error_head:

pwa-wp/wp-includes/default-filters.php

Lines 20 to 21 in a9213f0

	add_action( 'wp_head', 'wp_add_error_template_no_robots' );
	add_action( 'error_head', 'wp_add_error_template_no_robots' );

Perhaps you have a template that is calling wp_head() unexpectedly?

[westonruter]

@Youdaman Sorry for the delay on this. Another user reported the same issue in the support forums. I was able to reproduce the issue and I've submitted a fix: #712. Could you see if that fixes the issue for you if you're still using the plugin?

[pooja-muchandikar]

Hi @westonruter,

Me and @thelovekesh tried to reproduce the issue but we were not able to reproduce it. Can you please help us to QA this issue?

cc: @maitreyie-chavan

[westonruter]

✅ QA Passed

This is how I could reproduce the issue by putting the following in a plugin:

add_action( 'plugin_loaded', function () {
	$query = new WP_Query();
	$query->parse_query( 's=test' );
} );

Before the change I would get errors like:

Notice: is_offline was called incorrectly. Conditional query tags do not work before the query is run. Before then, they always return false. Please see Debugging in WordPress for more information. (This message was added in version 3.1.0.) in /app/public/core-dev/src/wp-includes/functions.php on line 5775

After the change, the notices go away.