Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update googleapis version #111

Closed
wants to merge 25 commits into from
Closed

Update googleapis version #111

wants to merge 25 commits into from

Conversation

JuanMaRuiz
Copy link
Contributor

Update googleapis to v40.0.0.

  • Test ✅
  • Linter ✅

JuanMaRuiz and others added 24 commits October 26, 2019 17:11
- Removed call to api.
- Added test to options handler instead
- Merge branch 'feature-optimizing-test' of https://github.com/JuanMaRuiz/psi into feature-optimizing-test
- Removed api-response-test
Co-Authored-By: Shane Exterkamp <[email protected]>
Co-Authored-By: Shane Exterkamp <[email protected]>
* Update index file to use new api
* Update googleapis dependency
@exterkamp
Copy link
Collaborator

This is a duplicate of #110 seems like?

@JuanMaRuiz
Copy link
Contributor Author

JuanMaRuiz commented Mar 11, 2020

This is a duplicate of #110 seems like?

Yes. I saw the build failing and I thought to provide a working example.

The only difference is the approach to get the same result.

Feel free to close and merge the previous one.

Best regards.

@JuanMaRuiz JuanMaRuiz closed this Mar 15, 2020
@JuanMaRuiz JuanMaRuiz reopened this Mar 15, 2020
@JuanMaRuiz
Copy link
Contributor Author

Close because this update has been already merge

@JuanMaRuiz JuanMaRuiz closed this Mar 15, 2020
@JuanMaRuiz JuanMaRuiz deleted the update-googleapis-version branch March 15, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants