-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update googleapis version #111
Closed
JuanMaRuiz
wants to merge
25
commits into
GoogleChromeLabs:master
from
JuanMaRuiz:update-googleapis-version
Closed
Update googleapis version #111
JuanMaRuiz
wants to merge
25
commits into
GoogleChromeLabs:master
from
JuanMaRuiz:update-googleapis-version
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-optimizing-test
- Removed call to api. - Added test to options handler instead
- Merge branch 'feature-optimizing-test' of https://github.com/JuanMaRuiz/psi into feature-optimizing-test - Removed api-response-test
…iz/psi into feature-optimizing-test
Co-Authored-By: Shane Exterkamp <[email protected]>
Co-Authored-By: Shane Exterkamp <[email protected]>
* Update index file to use new api * Update googleapis dependency
This is a duplicate of #110 seems like? |
Yes. I saw the build failing and I thought to provide a working example. The only difference is the approach to get the same result. Feel free to close and merge the previous one. Best regards. |
Close because this update has been already merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update googleapis to v40.0.0.