Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package googleapis to ^47.0.0 #110

Merged
merged 2 commits into from
Mar 14, 2020

Conversation

tonysan
Copy link
Contributor

@tonysan tonysan commented Mar 10, 2020

Update package googleapis per npm audit results

tonysan added 2 commits March 9, 2020 17:14
Update package `googleapis` per [npm audit results](https://npmjs.com/advisories/791)

Also, the lowest version [Google API documentation site](https://googleapis.dev/nodejs/googleapis/40.0.0/index.html) is `40.0.0` hence updating to that version.
@tonysan tonysan changed the title Update package googleapis to ^40.0.0 Update package googleapis to ^47.0.0 Mar 11, 2020
@@ -34,7 +34,7 @@
],
"dependencies": {
"chalk": "^2.4.2",
"googleapis": "^38.0.0",
"googleapis": "^47.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should actually work from 40.0.0 and above

@tonysan
Copy link
Contributor Author

tonysan commented Mar 11, 2020

Other notes:

It is possible to move to util.promisify and remove pify as a dependency (but would require node>=8), that'll probably need its own PR with mostly move then to await, or configure xo to ignore those.

While fixing this bug, I found there is a Google HTTP API does exactly the same thing, I don't really need this PR to be merged for my other code to work, so feel free to merge/close it.

Copy link
Collaborator

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested and build passed!

@exterkamp exterkamp merged commit b39846e into GoogleChromeLabs:master Mar 14, 2020
@tonysan tonysan deleted the patch-1 branch March 20, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants