Updates to latest dependencies, and transpilation targets #1658

jeffposnick · 2018-09-23T01:58:08Z

Fixes #1654, fixes #1655, fixes #1656, fixes #1542, fixes #1574, to be merged into the next branch.

This has a whole host of updates to the various dependencies and devDependencies, bumping up most of them to the latest releases across all of our package.json.

Along with that, I've updated the transpilation targets to node 6 (which is required by some of the updated dependencies) and Chrome 56. (If it turns out that we need to stick with Chrome 51, we can change that back.)

There are a lot of whitespace changes in this PR, as the updated eslint config was not happy with some of our previous formatting. (Link to view with whitespace changes hidden.)

The webpack tests are currently failing, as I need to update a whole bunch of those constants in order to get them to pass. They need to be updated whenever any of the webpack-related dependencies change, and I'm going to hold off on remediating everything (or scripting an update) until I make sure that we don't have any other updates.

jeffposnick · 2018-09-23T01:59:01Z

package.json

    "serve-index": "^1.9.1",
-    "service-worker-mock": "^1.7.2",
+    "service-worker-mock": "^1.9.3",
    "shelving-mock-indexeddb": "github:philipwalton/shelving-mock-indexeddb#d2c5e52b6f9903026f5bac31cbe758cbebd98661",


@philipwalton as far as I can tell, the change in your fork never made it to the upstream project, so we're still pinned to this.

Yeah, I'll file an issue to upstream that.

jeffposnick · 2018-09-23T01:59:57Z

package.json

+    "@babel/plugin-transform-runtime": "^7.1.0",
+    "@babel/preset-env": "^7.1.0",
+    "@google-cloud/storage": "^2.0.3",
+    "@octokit/rest": "^15.12.0",
    "@std/esm": "^0.26.0",


I tried moving to the esm project (which replaced @std/esm), but there are a lot of breaking changes and I couldn't get our unit test runner happy. So we're still stuck on this older version until we can investigate further.

* Fixes workbox dependencies * Fixes the depcheck

philipwalton

I wonder if it makes sense to split this into two different PRs. One that just handles the formatting changes, and one that handles all the other changes.

philipwalton · 2018-10-01T18:19:22Z

.eslintrc.js

@@ -20,13 +20,14 @@ module.exports = {
  rules: {
    "jsdoc/check-types": 2,
    "jsdoc/newline-after-description": 2,
+    'indent': ['error', 2],


What's this being added for?

Oh, now that I'm looking at the rest of the changes, I see what you're doing. But technically this isn't consistent with Google style because in some cases Google style recommends indenting 4 spaces (e.g. line continuations and stuff like that).

The google eslint package v0.10.0 adds an indentation rule more inline with what's recommended by Google JS style. It's probably worth just upgrading to that.

As discussed in person, there are going to be a lot of additional files that need whitespace adjustment if we don't include this.

We're already using "eslint-config-google": "^0.10.0" as part of this PR.

Let's do separate PR to remove this override and get all the whitespace consistent rather than including any more changes in this PR.

philipwalton · 2018-10-01T18:23:36Z

gulp-tasks/utils/build-node-package.js

@@ -32,7 +32,7 @@ module.exports = (packagePath) => {
      // are only included in our Rollup bundles once, even if they're used
      // in multiple source files.
      // See https://github.com/rollup/rollup-plugin-babel#helpers
-      'transform-runtime',
+      '@babel/transform-runtime',


BTW, if we're getting rid of the regenerator runtime polyfill, we may not need this at all anymore.

We still need it for the node libraries, since we're targeting node 6, and that doesn't support async/await.

googlebot · 2018-10-03T15:10:28Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

jeffposnick · 2018-10-03T15:11:41Z

I've merged in the 3.6.2 changes to this PR, just so we don't drift too far from master.

philipwalton · 2018-10-03T15:51:02Z

package.json

    "serve-index": "^1.9.1",
-    "service-worker-mock": "^1.7.2",
+    "service-worker-mock": "^1.9.3",
    "shelving-mock-indexeddb": "github:philipwalton/shelving-mock-indexeddb#d2c5e52b6f9903026f5bac31cbe758cbebd98661",


Yeah, I'll file an issue to upstream that.

philipwalton · 2018-10-03T15:55:46Z

gulp-tasks/utils/rollup-helper.js

    };
    plugins.push(babel(babelConfig));

    let minifyBuild = buildType === constants.BUILD_TYPES.prod;
    if (minifyBuild) {
-      const uglifyOptions = {
+      const terserOptions = {
        mangle: {
          properties: {


I discovered recently that we probably need to enable the option to make property mangling consistent across files (when we're outputting multiple files). I can file an issue to do that in a separate PR.

jeffposnick added 4 commits September 21, 2018 16:40

WIP.

1653165

WIP.

b2cd2ac

Linting.

4fbb626

Removing browser-sync.

2276426

jeffposnick added the Breaking Change Denotes a "major" semver change. label Sep 23, 2018

jeffposnick added this to the v4 milestone Sep 23, 2018

jeffposnick requested a review from philipwalton September 23, 2018 01:58

jeffposnick commented Sep 23, 2018

View reviewed changes

jeffposnick mentioned this pull request Sep 23, 2018

[ON HOLD] workbox-cli dependencies updates #1609

Closed

arcanis and others added 3 commits September 28, 2018 10:22

Fixes workbox dependencies (#1667)

9666462

* Fixes workbox dependencies * Fixes the depcheck

v3.6.2

38f132b

3.6.2 metadata (#1669)

59e7d4f

philipwalton requested changes Oct 1, 2018

View reviewed changes

Merging master.

337c824

philipwalton approved these changes Oct 3, 2018

View reviewed changes

jeffposnick merged commit 7a65759 into next Oct 3, 2018

jeffposnick deleted the package-json-updates branch October 3, 2018 16:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to latest dependencies, and transpilation targets #1658

Updates to latest dependencies, and transpilation targets #1658

jeffposnick commented Sep 23, 2018 •

edited

Loading

jeffposnick Sep 23, 2018

philipwalton Oct 3, 2018

jeffposnick Sep 23, 2018

philipwalton left a comment

philipwalton Oct 1, 2018

philipwalton Oct 1, 2018

jeffposnick Oct 3, 2018

philipwalton Oct 3, 2018

philipwalton Oct 1, 2018

jeffposnick Oct 3, 2018

googlebot commented Oct 3, 2018

jeffposnick commented Oct 3, 2018

philipwalton Oct 3, 2018

philipwalton Oct 3, 2018

Updates to latest dependencies, and transpilation targets #1658

Updates to latest dependencies, and transpilation targets #1658

Conversation

jeffposnick commented Sep 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

philipwalton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

googlebot commented Oct 3, 2018

jeffposnick commented Oct 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeffposnick commented Sep 23, 2018 •

edited

Loading