Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbox Wizard breaks #1574

Closed
damianwojcik opened this issue Jul 12, 2018 · 10 comments
Closed

Workbox Wizard breaks #1574

damianwojcik opened this issue Jul 12, 2018 · 10 comments
Assignees
Labels
Bug An issue with our existing, production codebase. workbox-cli

Comments

@damianwojcik
Copy link

damianwojcik commented Jul 12, 2018

Library Affected:
workbox-cli

Browser & Platform:
Windows, Node

Issue:
workbox wizard breaks at the 3rd prompt > Where would you like your service worker file to be saved?

code_2018-07-12_16-29-16

@jeffposnick jeffposnick added Bug An issue with our existing, production codebase. workbox-cli labels Jul 12, 2018
@kryptonian41
Copy link

yupp m facing the same bug

@jeffposnick
Copy link
Contributor

jeffposnick commented Jul 26, 2018

Apologies that you both are running into this.

I tried to reproduce and I was not able to. I'm using PowerShell with node v8.11.3 installed, and the latest workbox-cli v3.4.1. Are you using those versions, or perhaps an older version?

Also, can you reproduce it if you try running the wizard in a different directory?

untitled

@Hesammousavi
Copy link

Hesammousavi commented Aug 19, 2018

i noticed that because of nodejs version
when i used nodejs version 10.* , i got the same error
but i removed nodejs 10.* and installed nodejs version 8.* and my problme solved

@jeffposnick
Copy link
Contributor

Okay, so this is pretty strange.

I've installed node v10.9.0 and have been able to reproduce some of the freezing when using PowerShell and the Node.js command prompt on Windows (I'm testing on a Windows Server installation, actually).

I can't reproduce the issue when using the Git Bash shell on Windows, so I think this is particular to shells that use Windows-style paths.

What seems to help is changing a few instances of asynchronous calls to their synchronous version. This gets a bit tricky, since the original source is transpiled with the regenerator runtime, to ensure that we support node v6.

const stat = await fse.stat(globDirectory);

is an example of one spot that causes hangs, and it progresses past that if I change the code locally to fse.statSync().

I'm going to debug more, and thanks for everyone's patience.

@jeffposnick jeffposnick self-assigned this Aug 20, 2018
@jeffposnick
Copy link
Contributor

jeffposnick commented Aug 20, 2018

Quick update—bumping the dependency versions for the various libraries used by workbox-cli seems to fix it in my local testing. I'll file a PR, but since those dependency updates break node v4 support, it will have to wait until the next major release of Workbox.

@yashints
Copy link

yashints commented Sep 5, 2018

@jeffposnick Any news on this? Facing the same issue and I see the PR is pending.
BTW: when I use Git Bash the wizard works fine, but the menu selection on it is horrible 😢

@jeffposnick
Copy link
Contributor

jeffposnick commented Oct 11, 2018

Using workbox-cli@alpha on npm should pick up our 4.0.0 alpha releases now, which contain a fix.

Feel free to read the release notes and confirm that it's working for you now.

@ronnievsmith
Copy link

ronnievsmith commented Nov 28, 2018

I encountered this running Node v8.1.0. Using nvm, I switched to Node v8.9.0 and issue was resolved.

		nvm install v8.9.0
		nvm alias default v8.9.0

@seangwright
Copy link

I'm using

  • Gitbash 2.19.1.windows.1
  • Windows 10
  • node v10.9.0

I experienced the same issue listed by the OP but switching to 4.0.0-beta.0 of workbox-cli fixed everything.

@MatteoGioioso
Copy link

Same issue here. Workbox-cli wizard stops at the first question

  • Window 7 professional
  • git version 2.19.0
  • workbox-cli 3.6.3

installing 4.0.0-beta.0 fixed everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An issue with our existing, production codebase. workbox-cli
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants