Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading static video to offline storage via Fetch API #24

Closed
jwold opened this issue Feb 8, 2021 · 5 comments
Closed

Downloading static video to offline storage via Fetch API #24

jwold opened this issue Feb 8, 2021 · 5 comments

Comments

@jwold
Copy link

jwold commented Feb 8, 2021

Feature description

As a user, I should be able to download a static video to offline storage via fetch


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Design: Contingent a little bit on the design. However a user should be able to view any video on the site, select download, and know that their action is happening.

Relates to #24, #25, #26, #35

Notes

Implementation brief

QA testing instructions

Demo

Changelog entry

@jwold jwold changed the title As a user, I should be able to download a static video to offline storage via fetch Downloading static video to offline storage Feb 8, 2021
@jwold jwold added the Phase: 1 label Feb 8, 2021
@jwold jwold changed the title Downloading static video to offline storage Downloading static video to offline storage via Fetch API Feb 8, 2021
@jwold
Copy link
Author

jwold commented Feb 25, 2021

@daliamoya and @dero is this one unblocked by design?

@dero
Copy link
Collaborator

dero commented Feb 26, 2021

@jwold Yes, it is.

@dero
Copy link
Collaborator

dero commented Mar 1, 2021

This is implemented and merged to develop.

@kkalarickal
Copy link

Verified on KINO Staging Site on Google Chrome.

Given a end user navigates to the site
When she clicks on the download icon or "Make Available Offline" button
Then the DASH encoded video stream is downloaded to the IndexedDB storage by the service worker
And then is made available for replay, download, deletion when browser/service worker is Offline.

Tested this on Galaxy S21 on Chrome, Safari 14 on Mac and via emulation on Google Chrome DevTools.

Have filed bugs #84 , #86, #87, and #89 related to this ticket.

As far as acceptance criteria go, this ticket has passed QA for phase 1 of the application.

Cc: @dero @jwold

@kkalarickal kkalarickal self-assigned this Mar 11, 2021
@dero
Copy link
Collaborator

dero commented Mar 11, 2021

Thank you, @kkalarickal, good finds!

We already have a PR for #84 – I linked the ticket to the PR.

I'm going to respond to and / or address the rest tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants