Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini Load Test: Simultaneously downloading multiple videos, pausing and restarting does not complete download #89

Closed
kkalarickal opened this issue Mar 11, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@kkalarickal
Copy link

Bug Description

Scenario: A user clicks download on a bunch of videos. In between, she pauses some of the video downloads, and then goes back and restarts. Trying this a few times, it looks like there is something that causes the video to show downloading, but there is no activity on the network tab and the service worker Storage > IndexedDB > VideoID shows done:false for a long time.

Expected Behaviour

Loading up the service worker to do multiple downloads should not result in a frozen state where one of the downloads does not complete.

Steps to reproduce

  1. Go to KINO Staging Site on Google Chrome
  2. Click on download for a bunch of videos
  3. Go to Manage Downloads and pause and restart a lengthy video
  4. See discrepancies listed.

Screenshots

Screencast showing long download stuck after pause+restart: https://share.getcloudapp.com/v1uN7mnE

Additional context

  • Project version: da8ec7d
  • Node version: n.a.
  • OS: Win10
  • Browser: chrome
  • Device: Galaxy S III

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@dero
Copy link
Collaborator

dero commented Mar 12, 2021

@kkalarickal I'm not able to reproduce this issue. Are you sure you weren't viewing stale data in the database?

image

Every VideoDownload instance is independent and there shouldn't be any global state that would interfere with its operation. In other words – concurrent downloads of many files will be limited by bandwidth, but the download progress bars should be unaffected, the data should be downloaded and stored in IDB properly.

It would be useful to try to pinpoint more detailed information about under which conditions the downloads fail.

@kkalarickal
Copy link
Author

Yes. I will dig a bit deeper to come up with a consistent way to recreate this. Thank you for the tip about removing stale data and setting the expectation that download instances are independent and should not interfere with each other as long as bandwidth is available. I will work on this a bit more and then report back.

@kkalarickal
Copy link
Author

I am going to junk this bug since I cannot recreate this any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants