-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TR download metadata file in background #349
Comments
We need to close connection after checking if resource exists. Also how are you going to sync metadata loading and metadata validation timers? If metadata is very big system can start validation earlier than it will be downloaded. |
When it is completely downloaded , than only we are adding it in validation queue.So it is in sync for both metadata downloading and validation timer. |
I added comments to commit: 68398a4 Also I don't like method:
We should not pass instance of action to service. If we need instance we need to call Seam methods to do that. Why we can't just set status of TR to "Download metadata" and update validation timer to use this as flag to trigger it download? |
Should this issue be closed? |
@nynymike yes we cann close this issue. |
On TR save server is trying to download this metadata file fully. A result user is waiting at leas one minute. Download and validate metadata in background (i.e in new thread.).and We should also check if remote resource exists and cancel download it.
The text was updated successfully, but these errors were encountered: