Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML Trust Relationship: Multi-Party Federation Metadata Re-Design #310

Closed
nynymike opened this issue Jul 26, 2016 · 10 comments
Closed

SAML Trust Relationship: Multi-Party Federation Metadata Re-Design #310

nynymike opened this issue Jul 26, 2016 · 10 comments
Assignees
Labels
bug enhancement libs update, re-factroring, etc. High Priority
Milestone

Comments

@nynymike
Copy link
Contributor

nynymike commented Jul 26, 2016

image

The old federation page has a bad design... It just crashed my browser session because the page became unresponsive.

The InCommon metadata aggregate is now 36MB xml file, it used to be 10MB. I think its breaking down due to the fact that InCommon federation starting including European federation (interfederation with EduGain). Even before this the federation page was slow.

Here are my suggestions:

  1. Add a new select box called Entity Type with values "Single SP" and "Federation / Aggregate"
  2. If Entity Type "Federation / Aggregate" is selected in the Metadata Location input, the form fields for "SP Logout URL", "Configure RP", "Enable InCommon R&S" and "Released" should be hidden in the fom view.
  3. If Entity Type "Federation / Aggregate" is selected, remove the Entity Location drop down values, "Generate" and "Federation"
  4. Change label "Metadata Type" to "Metadata Location"
  5. Check that federation / aggregate validation happens in the background.
@nynymike nynymike added bug enhancement libs update, re-factroring, etc. High Priority labels Jul 26, 2016
@nynymike nynymike added this to the CE 2.4.5 milestone Jul 26, 2016
@nynymike nynymike assigned shekhar16 and unassigned yurem Aug 26, 2016
@nynymike
Copy link
Contributor Author

Shekhar, this is urgent. Many of our university customers use Federation metadata, and it's totally not working to either import, use create a trust relationship. We're going to need to find a way to parse this file on the server side, and use some communication with the browser to enable selection.

shekhar16 pushed a commit that referenced this issue Aug 29, 2016
@shekhar16
Copy link
Contributor

Mike, all UI issues are done.Please let me know about
5 .Check that federation / aggregate validation happens in the background.

@yurem
Copy link
Contributor

yurem commented Sep 9, 2016

Regarding point 5. Yes, validation happens in independent process on server.
But I think there are 2 design problems additionally:

  1. On TR save server is trying to download this metadata file fully. A result user is waiting at leas one minute... I believe we can move this to validation process. On TR save we should check if remote resource exists and cancel download it.
  2. The TR page with this metadata is very big: http://md.incommon.org/InCommon/InCommon-metadata.xml
    I get server error after some time. We should not load all federation URL on TR load. We should use filters. Once user enter keyword we should load only URL which conforms this filter. This will make U more user friendly.

@nynymike
Copy link
Contributor Author

nynymike commented Sep 9, 2016

I have one more concern on validation. Note, that is an http url... if you read the Metadata Aggregates page, you'll notice:

All metadata aggregates are signed using the same metadata signing key and the SHA-256 digest
algorithm. To verify the signature on an aggregate, a consumer must obtain an authentic copy of 
the  InCommon Metadata Signing Certificate. 

We need a form field where the admin can specify the URL of the signing certificate.

shekhar16 pushed a commit that referenced this issue Sep 11, 2016
@shekhar16
Copy link
Contributor

@shekhar16
Copy link
Contributor

shekhar16 commented Sep 13, 2016

Instead of download metadata on validation time , I created a new thread when we are saving TR.
Any suggestions....

@nynymike
Copy link
Contributor Author

I think it makes sense to download and validate in the background.

@shekhar16
Copy link
Contributor

#349

@yurem
Copy link
Contributor

yurem commented Oct 4, 2016

Fix looks fine now

@nynymike
Copy link
Contributor Author

We need to align with Shib IDP v3. It's unfortunate, but some changes were bound to get caught in the middle of the migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement libs update, re-factroring, etc. High Priority
Projects
None yet
Development

No branches or pull requests

4 participants