Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GitVersionInformation C# template ('const string' instead of 'static string') #3102

Closed

Conversation

kvasnevskyivlad
Copy link

@kvasnevskyivlad kvasnevskyivlad commented Apr 27, 2022

Changed GitVersionInformation C# template from static string to const string as discussed in #3095. Also I tested this with reflection and I didn't find any problems, I am able to get GitVersionInformation through reflection, maybe I missed smth. But as was mentioned in #3095 this change should be breaking, so if it's breaking please let me know what exactly stopped working and how I can test it.

@arturcic arturcic requested a review from asbjornu April 27, 2022 11:31
@asbjornu
Copy link
Member

asbjornu commented May 4, 2022

@kvasnevskiy, the breaking change is how existing reflection code works. If we change from static string to const string, existing code that performs reflection to find the GitVersionInformation class and its data, will need to change.

Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to implement this, I just think we need to do it on main and fold it into v6 and not release it as a part of v5.

@kvasnevskyivlad
Copy link
Author

I'm not opposed to implement this, I just think we need to do it on main and fold it into v6 and not release it as a part of v5.

ok, If I get you right @asbjornu, I just need to reopen PR with main as target branch?

@arturcic
Copy link
Member

arturcic commented May 6, 2022

@kvasnevskiy right

@kvasnevskyivlad
Copy link
Author

Closed and will reopen on main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants