Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GitVersionInformation C# template ('const string' instead of 'static string') #3095

Closed
kvasnevskyivlad opened this issue Apr 20, 2022 · 5 comments · Fixed by #3113
Closed

Comments

@kvasnevskyivlad
Copy link

kvasnevskyivlad commented Apr 20, 2022

Similar request was already open #1376 and then closed. But I see that it's still static string. Can template be changed to const string? Because I want to use GitVersionInformation in attributes and value there should be constant,

@arturcic
Copy link
Member

@kvasnevskiy do you mind creating a PR for this?
As a starting point here https://github.com/GitTools/GitVersion/blob/support/5.x/src/GitVersion.Core/VersionConverters/GitVersionInfo/AddFormats/GitVersionInformation.cs, You might need to update some of the tests as well

@kvasnevskyivlad
Copy link
Author

@arturcic ok, I will create a PR for this.

@asbjornu
Copy link
Member

As mentioned by @jbaehr in #1376 (comment), the change from static to const is a breaking change. For more insight into the reflection side of things, please see #895 (comment), the linked issues and the surrounding discussion.

@arturcic
Copy link
Member

Closed by #3113

@arturcic arturcic modified the milestones: 6.x, 6.0.0-alpha.1 Dec 22, 2022
@arturcic
Copy link
Member

🎉 This issue has been resolved in version 6.0.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants