Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Dockerfile #1219

Merged
merged 4 commits into from
May 20, 2017
Merged

Improvements to Dockerfile #1219

merged 4 commits into from
May 20, 2017

Conversation

BenHall
Copy link
Contributor

@BenHall BenHall commented May 17, 2017

Related to #1218

Main fixes:

  • Set a version for Ubuntu. Currently using :latest which will change in future
  • Move commands to a single instruction, this reduces the total image size as cache can be cleared

RUN apt-get update
RUN apt-get install mono-complete -y
RUN echo "deb http://download.mono-project.com/repo/debian wheezy main" | tee /etc/apt/sources.list
.d/mono-xamarin.list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be on a new line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot. No, it shouldn't. I copied and pasted from my terminal window

Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JakeGinnivan JakeGinnivan merged commit cf29e64 into GitTools:master May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants