Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker improvements #1218

Closed
JakeGinnivan opened this issue May 17, 2017 · 2 comments
Closed

Docker improvements #1218

JakeGinnivan opened this issue May 17, 2017 · 2 comments

Comments

@JakeGinnivan
Copy link
Contributor

I am pretty new with Docker, what we have works but I wonder if anyone can make what we have better.

We have a base image at https://github.com/GitTools/GitVersion/tree/master/src/DockerBase, the mono image doesn't run libgit2 because wheezy is super old and glib2.15 doesn't run on it without adding experimental repos and updating.

So I went with an Ubuntu base image and put mono on it, this seems pretty heavy but seems to work.

Then https://github.com/GitTools/GitVersion/blob/master/Dockerfile builds off the base. Then we publish through our deploy script at https://github.com/GitTools/GitVersion/blob/master/deploy.cake#L196

If you can improve it, send a pull request, it would be greatly appreciated.

@mkoertgen
Copy link
Contributor

Hi @JakeGinnivan. I did a quick evaluation on how to wrap GitVersion inside docker.
First i tried dotnetcore & mono-slim base images but finally arrived at adding gitversion (latest github release) and git to the latest mono image.

You can review my evaluation experiment here: https://github.com/mkoertgen/docker.gitversion/blob/master/Dockerfile

@asbjornu
Copy link
Member

I believe this can be closed due to the merging of #1215, #1269, #1344, #1422, #1432 and #1485 which all improve our Docker story. I've also created #1572 to discuss which further, concrete, improvements we can make to the current naming scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants