-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-1050] Supporting the new alt text feature in the WEB SDK #331
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,51 +1,48 @@ | ||
language: node_js | ||
os: linux | ||
node_js: | ||
- '14' | ||
- '14' | ||
|
||
env: | ||
# skip Puppeteer download, only needed for Netlify build | ||
- PUPPETEER_SKIP_DOWNLOAD=1 | ||
# skip Puppeteer download, only needed for Netlify build | ||
- PUPPETEER_SKIP_DOWNLOAD=1 | ||
|
||
addons: | ||
apt: | ||
packages: | ||
- libgconf-2-4 | ||
apt: | ||
packages: | ||
- libgconf-2-4 | ||
|
||
cache: | ||
yarn: true | ||
directories: | ||
- 'node_modules' | ||
- '~/.cache' | ||
yarn: true | ||
directories: | ||
- 'node_modules' | ||
- '~/.cache' | ||
|
||
before_script: | ||
- yarn global add license-checker | ||
- yarn run lerna bootstrap | ||
- git checkout . | ||
- yarn run cy:verify | ||
- yarn run cy:info | ||
- yarn global add license-checker | ||
- yarn run lerna bootstrap | ||
- git checkout . | ||
- yarn run cy:verify | ||
- yarn run cy:info | ||
|
||
script: | ||
- yarn run check-licenses | ||
- yarn run dependency-cruiser | ||
- yarn run lint | ||
- yarn test | ||
# All Percy snapshots except SearchBar have been moved to Cypress, to avoid confusion disable the old "snapshot" command. | ||
# When the Cypress setuisbe verified, this command might be removed. | ||
# - yarn run snapshot | ||
- yarn run cy:run --record --key ${CYPRESS_RECORD_KEY} | ||
# after all tests finish running we need | ||
# to kill all background jobs (like "npm start &") | ||
# this avoids flake in Travis jobs | ||
- kill $(jobs -p) || true | ||
- yarn run check-licenses | ||
- yarn run dependency-cruiser | ||
- yarn run lint | ||
- yarn test | ||
# All Percy snapshots except SearchBar have been moved to Cypress, to avoid confusion disable the old "snapshot" command. | ||
# When the Cypress setuisbe verified, this command might be removed. | ||
# - yarn run snapshot | ||
- yarn run cy:run --record --key ${CYPRESS_RECORD_KEY} | ||
|
||
before_deploy: | ||
- echo "//registry.npmjs.org/:_authToken=\${NPM_TOKEN}" >> $HOME/.npmrc | ||
- echo "//registry.npmjs.org/:_authToken=\${NPM_TOKEN}" >> $HOME/.npmrc | ||
|
||
deploy: | ||
if: branch = master AND tag IS present | ||
provider: script | ||
- provider: script | ||
script: 'yarn run lerna:publish' | ||
cleanup: false | ||
skip_cleanup: true | ||
on: | ||
tags: true | ||
condition: $TRAVIS_COMMIT_MESSAGE =~ ^Publish | ||
branch: master | ||
condition: $TRAVIS_COMMIT_MESSAGE =~ ^Publish |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pshoniuk I believe the problem is that tags don't run on
branch: master
, as you can see in the previous commit I had this setting before tryingtags: true
Unless you changed something else I missed, or Travis behavior has changed, this probably won't work
Edit: I see you removed the
if
, so maybe this will work 👍There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@giannif I think the root issue was this line. It just killed all the background processes, including some Travis agents, and thus the deployment was skipped. But to be sure, we need to check this assumption