[SDK-1050] Supporting the new alt text feature in the WEB SDK #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshoniuk
force-pushed
the
feat/SDK-1050
branch
2 times, most recently
from
42ba090
to
45deb38
Compare
pshoniuk
force-pushed
the
feat/SDK-1050
branch
from
45deb38
to
98f60b2
Compare
giannif
reviewed
Nov 29, 2022
| skip_cleanup: true | ||
| on: | ||
| tags: true |
There was a problem hiding this comment.
@pshoniuk I believe the problem is that tags don't run on branch: master, as you can see in the previous commit I had this setting before trying tags: true
Unless you changed something else I missed, or Travis behavior has changed, this probably won't work
Edit: I see you removed the if, so maybe this will work 👍
LBBO
added a commit
to LBBO/giphy-js
that referenced
this pull request
Nov 29, 2022
This is a desperate and experimental attempt to fix the pipeline, since it works for that branch
LBBO
added a commit
to LBBO/giphy-js
that referenced
this pull request
Nov 29, 2022
This is a desperate and experimental attempt to fix the pipeline, since it works for that branch
|
Sorry for the spam 😅 I was hoping the amended commit wouldn't appear here as well. Anyway, I'm just hoping that your changes to the travis config will fix my pipeline as well and somehow the whitespaces didn't survive my copy paste 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.