Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry picks minor fixes for v1.4 #255

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Cherry picks minor fixes for v1.4 #255

merged 4 commits into from
Aug 16, 2022

Conversation

MuellerSeb
Copy link
Member

@MuellerSeb MuellerSeb commented Aug 10, 2022 •
edited
Loading

Cherry picks from #243 to be included in v1.4:

  • add bounds checks for optional arguments when resetting by class attribute
  • Cython: solve -Wsometimes-uninitialized warning
  • minor coverage improvements

@MuellerSeb MuellerSeb requested a review from LSchueler August 10, 2022 16:05
@MuellerSeb MuellerSeb added the enhancement New feature or request label Aug 10, 2022
@MuellerSeb MuellerSeb added this to the v1.4 milestone Aug 10, 2022
LSchueler
LSchueler reviewed Aug 15, 2022
View reviewed changes
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all sensible changes, but I fear that this will lead directly into merge hell. How about merging PR #243 and remove the cherry picking from this PR?

@MuellerSeb
Copy link
Member Author

These are all sensible changes, but I fear that this will lead directly into merge hell. How about merging PR #243 and remove the cherry picking from this PR?

But merging this and rebasing #243 should also work, or? I don't want to include #243 in 1.4 just now, that is why I cherry picked the fixes from there.

@MuellerSeb MuellerSeb merged commit ebefaa6 into main Aug 16, 2022
@MuellerSeb MuellerSeb deleted the cherry_picks_minor_fixes branch August 16, 2022 18:52
@MuellerSeb MuellerSeb mentioned this pull request Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LSchueler LSchueler LSchueler left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@MuellerSeb @LSchueler