Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: (Exponential-)Integral model #243

Merged
merged 8 commits into from
Nov 3, 2022
Merged

Add: (Exponential-)Integral model #243

merged 8 commits into from
Nov 3, 2022

Conversation

MuellerSeb
Copy link
Member

@MuellerSeb MuellerSeb commented Jun 20, 2022 •
edited
Loading

  • adding a new model derived from the Exponential Integral named Integral
  • fix approximation of Matern spectrum for big nu

@MuellerSeb MuellerSeb added the enhancement New feature or request label Jun 20, 2022
@MuellerSeb MuellerSeb added this to the v1.4 milestone Jun 20, 2022
@MuellerSeb MuellerSeb self-assigned this Jun 20, 2022
@MuellerSeb MuellerSeb changed the title New Model: ExpIntegral model Add: ExpIntegral model Jun 20, 2022
@MuellerSeb MuellerSeb changed the title Add: ExpIntegral model Add: ExpIntegral model + opt_arg bounds check Jun 20, 2022
@MuellerSeb MuellerSeb requested a review from LSchueler August 9, 2022 12:29
@MuellerSeb MuellerSeb modified the milestones: v1.4, v1.5 Aug 10, 2022
@MuellerSeb MuellerSeb mentioned this pull request Aug 10, 2022
Merged
LSchueler
LSchueler reviewed Aug 15, 2022
View reviewed changes
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gimme more cov. models! :-) Nice!
I think it would be better, if you explicitly test the ExpInt model in test_covmodel.py.

I was never sure how much error checking we should include in the Cython-code. But as this will hopefully one day be legacy code, I think your fix is fine.

@MuellerSeb MuellerSeb force-pushed the 20220620_add_expint branch from 52aae1a to 7e5f926 Compare August 16, 2022 18:52
@MuellerSeb
Copy link
Member Author

Rebase after #255 worked fine.

@MuellerSeb MuellerSeb changed the title Add: ExpIntegral model + opt_arg bounds check Add: ExpIntegral model Oct 11, 2022
@MuellerSeb MuellerSeb changed the title Add: ExpIntegral model Add: (Exponential-)Integral model Oct 19, 2022
@MuellerSeb MuellerSeb requested a review from LSchueler October 19, 2022 13:17
@MuellerSeb MuellerSeb modified the milestones: v1.5, v1.4.1 Oct 29, 2022
LSchueler
LSchueler approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

@MuellerSeb MuellerSeb merged commit 39ca4d6 into main Nov 3, 2022
@MuellerSeb MuellerSeb deleted the 20220620_add_expint branch November 3, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LSchueler LSchueler LSchueler approved these changes

Assignees

@MuellerSeb MuellerSeb

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@MuellerSeb @LSchueler