Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12124] GNIP 100: Assets #12338

Merged
merged 10 commits into from
Jul 3, 2024
Merged

[Fixes #12124] GNIP 100: Assets #12338

merged 10 commits into from
Jul 3, 2024

Conversation

mattiagiupponi
Copy link
Contributor

@mattiagiupponi mattiagiupponi commented Jun 18, 2024

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

mattiagiupponi and others added 2 commits June 18, 2024 11:49
* [Fixes #12124] GNIP 100: Assets
---------

Co-authored-by: etj <[email protected]>
[Fixes #12226] Directory assets
---------
Co-authored-by: etj <[email protected]>
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jun 18, 2024
@mattiagiupponi mattiagiupponi marked this pull request as ready for review June 18, 2024 09:57
@mattiagiupponi mattiagiupponi changed the title GNIP 100: introduction of assets [Fixes #12124] GNIP 100: introduction of assets Jun 18, 2024
@mattiagiupponi mattiagiupponi changed the title [Fixes #12124] GNIP 100: introduction of assets [Fixes #12124] GNIP 100: Assets Jun 18, 2024
@mattiagiupponi mattiagiupponi requested a review from etj June 18, 2024 09:58
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 68.04788% with 347 lines in your changes missing coverage. Please review.

Project coverage is 64.17%. Comparing base (eb9bfe0) to head (1c3ef8a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12338      +/-   ##
==========================================
+ Coverage   64.14%   64.17%   +0.03%     
==========================================
  Files         872      886      +14     
  Lines       52328    53279     +951     
  Branches     6478     6584     +106     
==========================================
+ Hits        33564    34194     +630     
- Misses      17275    17571     +296     
- Partials     1489     1514      +25     

* [Fixes #12341] Download handler fix
* [Fixes #12341] Assets: link generation (#12342)
---------

Co-authored-by: Emanuele Tajariol <[email protected]>
Copy link
Contributor

@etj etj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's to restore a mandatory argument made optional (or to explain why it was changed) and then it's ok for me (it's 99.99% of the code I did :D )

@etj
Copy link
Contributor

etj commented Jun 27, 2024

The PR should be REBASED AND MERGED

@giohappy giohappy merged commit 773a6e1 into master Jul 3, 2024
17 checks passed
@giohappy giohappy deleted the assets_master branch July 3, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assets: link generation Directory assets GNIP 100: Assets
3 participants