Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes #12226] Directory assets #12337

Merged
merged 13 commits into from
Jun 18, 2024
Merged

[Fixes #12226] Directory assets #12337

merged 13 commits into from
Jun 18, 2024

Conversation

mattiagiupponi
Copy link
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

etj and others added 13 commits May 28, 2024 17:06
@etj @mattiagiupponi
[Fixes #12124] GNIP 100: Assets (#12276)
3074b8e 
* [Fixes #12124] GNIP 100: Assets

* Fix migrations

* Add _create_asset_dir method

* [Fixes #12124] Fix data retriever to handle not default destination folders

* Support for assets in upload

* Point geonode-importer to branch assets_data_retriever

---------

Co-authored-by: Mattia <[email protected]>
@etj
[Fixes #12226] Directory assets
e0a1bf4
@mattiagiupponi @etj
[Fixes #12226] Fix asset test
4d4a6d7
@etj
Merge remote-tracking branch 'origin/master' into 12226_directory_ass…
d68b25f 
…ets_2
@mattiagiupponi
Merge branch 'master' of github.com:GeoNode/geonode into 12226_direct…
78e798c 
…ory_assets_2
@mattiagiupponi
Fix filename extraction for assets
c298791
@mattiagiupponi
Add asset api closed to not authenticated users
50eeef1
@mattiagiupponi
Add filename in asset link
548be79
@mattiagiupponi
Add filename in asset link
f20654f
@mattiagiupponi
fix build
99d3383
@mattiagiupponi
fix build
636f0d2
@mattiagiupponi
asset requirment updated
1ec0b67
@mattiagiupponi
Merge with assets master
f4aeeb2
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jun 18, 2024
@mattiagiupponi mattiagiupponi changed the title 12226 directory assets 4 [Fixes #12226] Directory assets Jun 18, 2024
@mattiagiupponi mattiagiupponi merged commit d008bad into assets_master Jun 18, 2024
4 of 11 checks passed
@mattiagiupponi mattiagiupponi deleted the 12226_directory_assets_4 branch June 18, 2024 09:55
giohappy pushed a commit that referenced this pull request Jul 3, 2024
@mattiagiupponi @giohappy
[Fixes #12226] Directory assets (#12337)
618a936 
[Fixes #12226] Directory assets
---------
Co-authored-by: etj <[email protected]>
giohappy pushed a commit that referenced this pull request Sep 24, 2024
@mattiagiupponi @etj
[Fixes #12326] Assets: implement migration for old uploaded files (#1…
09ffac7 
…2411)

* [Fixes #12124] GNIP 100: Assets (#12335)

* [Fixes #12124] GNIP 100: Assets
---------

Co-authored-by: etj <[email protected]>

* [Fixes #12226] Directory assets (#12337)

[Fixes #12226] Directory assets
---------
Co-authored-by: etj <[email protected]>

* [Fixes #12341] Asset download handler and link generator (#12343)

* [Fixes #12341] Download handler fix
* [Fixes #12341] Assets: link generation (#12342)
---------

Co-authored-by: Emanuele Tajariol <[email protected]>

* [Fixes #12326] Assets: implement migration for old uploaded files

* [Fixes #12326] Assets: implement migration for old uploaded files

* [Fixes #12326] Assets: implement migration for old uploaded files

* [Fixes #12326] rollback requirements

---------

Co-authored-by: etj <[email protected]>
Co-authored-by: Emanuele Tajariol <[email protected]>
giohappy pushed a commit that referenced this pull request Sep 24, 2024
@mattiagiupponi @etj @giohappy
[Fixes #12326] Assets: implement migration for old uploaded files (#1…
6056f5f 
…2411)

* [Fixes #12124] GNIP 100: Assets (#12335)

* [Fixes #12124] GNIP 100: Assets
---------

Co-authored-by: etj <[email protected]>

* [Fixes #12226] Directory assets (#12337)

[Fixes #12226] Directory assets
---------
Co-authored-by: etj <[email protected]>

* [Fixes #12341] Asset download handler and link generator (#12343)

* [Fixes #12341] Download handler fix
* [Fixes #12341] Assets: link generation (#12342)
---------

Co-authored-by: Emanuele Tajariol <[email protected]>

* [Fixes #12326] Assets: implement migration for old uploaded files

* [Fixes #12326] Assets: implement migration for old uploaded files

* [Fixes #12326] Assets: implement migration for old uploaded files

* [Fixes #12326] rollback requirements

---------

Co-authored-by: etj <[email protected]>
Co-authored-by: Emanuele Tajariol <[email protected]>
giohappy added a commit that referenced this pull request Sep 24, 2024
@giohappy @mattiagiupponi @etj
[Fixes #12326] Assets: implement migration for old uploaded files (#1…
5f2aa06 
…2411) (#12611)

* [Fixes #12124] GNIP 100: Assets (#12335)

* [Fixes #12124] GNIP 100: Assets
---------



* [Fixes #12226] Directory assets (#12337)

[Fixes #12226] Directory assets
---------


* [Fixes #12341] Asset download handler and link generator (#12343)

* [Fixes #12341] Download handler fix
* [Fixes #12341] Assets: link generation (#12342)
---------



* [Fixes #12326] Assets: implement migration for old uploaded files

* [Fixes #12326] Assets: implement migration for old uploaded files

* [Fixes #12326] Assets: implement migration for old uploaded files

* [Fixes #12326] rollback requirements

---------

Co-authored-by: mattiagiupponi <[email protected]>
Co-authored-by: etj <[email protected]>
Co-authored-by: Emanuele Tajariol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattiagiupponi @etj