[Fixes #10041] Review the thumbnail scaling process

[marthamareal]

ref #10041

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
• New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
• This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
• This PR passes the QA checks: flake8 geonode
• Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
• Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[lgtm-com]

This pull request introduces 6 alerts and fixes 2 when merging 7895c7b into 540024f - view on LGTM.com

new alerts:

• 6 for Unused import

fixed alerts:

• 2 for Unused local variable

[lgtm-com]

This pull request fixes 2 alerts when merging d52755c into 540024f - view on LGTM.com

fixed alerts:

• 2 for Unused local variable

[lgtm-com]

This pull request fixes 2 alerts when merging df7abe7 into 5d66cca - view on LGTM.com

fixed alerts:

• 2 for Unused local variable

[codecov]

Codecov Report

Merging #10046 (453eb1c) into master (a6a1901) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10046      +/-   ##
==========================================
+ Coverage   61.45%   61.48%   +0.03%     
==========================================
  Files         824      823       -1     
  Lines       50510    50482      -28     
  Branches     7760     7755       -5     
==========================================
- Hits        31041    31040       -1     
+ Misses      17794    17768      -26     
+ Partials     1675     1674       -1     

[giohappy]

@marthamareal is this code already covered with tests?

[lgtm-com]

This pull request fixes 2 alerts when merging 4faa1a3 into 2cca742 - view on LGTM.com

fixed alerts:

• 2 for Unused local variable

[marthamareal]

@marthamareal is this code already covered with tests?

The create_document_thumbnail is patched in some tests, however am going to add some tests for the size configured in settings and also thumbnail for non-image docs

[mattiagiupponi]

Hi @marthamareal, follows questions:

• In the issue, only the downscale from the document parts is mentioned, but I guess that changing the settings will have an impact also on the other resources. Can you confirm this?
• I guess that re-specify the default value in the models is redundant. The setting is static (which means that is always coded in the file) and already has defaulted, so in the future, if we need to change the default size, we can rely only on the settings without changing in other parts of the code
• The LGTM bot is raising a couple of issues with the variable names
• Can you please add a couple of tests to verify that is working as expected and that there aren't regressions for the other resources?

[marthamareal]

Hi @marthamareal, follows questions:

• In the issue, only the downscale from the document parts is mentioned, but I guess that changing the settings will have an impact also on the other resources. Can you confirm this?
• I guess that re-specify the default value in the models is redundant. The setting is static (which means that is always coded in the file) and already has defaulted, so in the future, if we need to change the default size, we can rely only on the settings without changing in other parts of the code
• The LGTM bot is raising a couple of issues with the variable names
• Can you please add a couple of tests to verify that is working as expected and that there aren't regressions for the other resources?

@mattiagiupponi I have updated the PR with tests and suggested changes. Changing the settings has no effect because the setting which was being used THUMBNAIL_GENERATOR_DEFAULT_SIZE does not exist so the code was always using the default given. The LGTM shows fixed issues no new issues. Other resources are not affected because they have tests regarding thumbs and are passing. (also tested manually).

[lgtm-com]

This pull request fixes 2 alerts when merging 4798ce5 into a6a1901 - view on LGTM.com

fixed alerts:

• 2 for Unused local variable

[lgtm-com]

This pull request fixes 2 alerts when merging d62477b into a6a1901 - view on LGTM.com

fixed alerts:

• 2 for Unused local variable

[lgtm-com]

This pull request fixes 2 alerts when merging 453eb1c into a6a1901 - view on LGTM.com

fixed alerts:

• 2 for Unused local variable

[giohappy]

Just a note for the future, we're dropping unoconv renderer since it's not maintained anymore, so it's unlikely that it will ever be installed.

Maybe we can consider the new alternative, unoserver, but not being installed by default we should in case consider to develop it as an external contrib moduke.

[mattiagiupponi]

note: LGTM raise an issue, but actually is fixed: