Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support older macOS versions in CI build #5697

Closed
wants to merge 1 commit into from
Closed

Support older macOS versions in CI build #5697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,13 @@ jobs:
libtool

- name: Build
env:
# the default Xcode (and macOS SDK) version can be found at
# <https://github.com/actions/runner-images/blob/main/images/macos/macos-15-Readme.md#xcode>
#
# then the minimal supported deployment target of that macOS SDK can be found at
# <https://developer.apple.com/support/xcode/#minimum-requirements>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for the change, but why these comments related to xcode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because macOS SDK is part of Xcode.

In the first link, you can see GitHub installed multiple versions of Xcode in the runner image, and each macOS SDK version is contained in one or more Xcode versions.

In fact, neither Xcode nor macOS SDK version matter now, because all recent macOS SDK versions support building for OS X 10.13. I just want to document where this 10.13 comes from.

MACOSX_DEPLOYMENT_TARGET: 10.13
run: release/build_macos.sh aarch64

# upload-artifact does not preserve permissions
Expand Down Expand Up @@ -242,6 +249,13 @@ jobs:
# autoconf and libtool are already installed on macos-13

- name: Build
env:
# the default Xcode (and macOS SDK) version can be found at
# <https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md#xcode>
#
# then the minimal supported deployment target of that macOS SDK can be found at
# <https://developer.apple.com/support/xcode/#minimum-requirements>
MACOSX_DEPLOYMENT_TARGET: 10.13
run: release/build_macos.sh x86_64

# upload-artifact does not preserve permissions
Expand Down