Support older macOS versions in CI build #5697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rom1v
reviewed
Dec 22, 2024
| # <https://github.com/actions/runner-images/blob/main/images/macos/macos-15-Readme.md#xcode> | ||
| # | ||
| # then the minimal supported deployment target of that macOS SDK can be found at | ||
| # <https://developer.apple.com/support/xcode/#minimum-requirements> |
There was a problem hiding this comment.
OK for the change, but why these comments related to xcode?
There was a problem hiding this comment.
Because macOS SDK is part of Xcode.
In the first link, you can see GitHub installed multiple versions of Xcode in the runner image, and each macOS SDK version is contained in one or more Xcode versions.
In fact, neither Xcode nor macOS SDK version matter now, because all recent macOS SDK versions support building for OS X 10.13. I just want to document where this 10.13 comes from.
rom1v
pushed a commit
that referenced
this pull request
Dec 23, 2024
Fixes #5649 <#5649> Fixes #5697<#5697> Signed-off-by: Romain Vimont <[email protected]>
|
Merged: 5b1229a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5649
These older OS versions are no longer supported by Apple, but the latest macOS SDK still supports building binaries for 10.13, and I see no downsides doing that.
I tested x86-64 build in a virtual machine running 10.15.7. I can't test the arm64 build.