Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle events on NumPad when NumLock is disabled #1188

Closed
wants to merge 3 commits into from
Closed

Handle events on NumPad when NumLock is disabled #1188

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c9eeb8
Handle events on NumPad when NumLock is disabled
jaafarbi Feb 29, 2020
1979043
Solve coding style issues
jaafarbi Mar 1, 2020
e63ca4e
Fix additional coding style issue
jaafarbi Mar 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions app/src/event_converter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,23 @@ convert_keycode(SDL_Keycode from, enum android_keycode *to, uint16_t mod,
if (mod & (KMOD_LALT | KMOD_RALT | KMOD_LGUI | KMOD_RGUI)) {
return false;
}

if (!(mod & (KMOD_NUM | KMOD_SHIFT))) {
// handling Numpad events when Num Lock is disabled
switch(from){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that there are some coding style issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some modifications regarding the coding style issues. Can you tell me what was exactly the issue?

Thank you

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! From now, I only notice that we need a space after switch.

MAP(SDLK_KP_6, AKEYCODE_DPAD_RIGHT);
MAP(SDLK_KP_4, AKEYCODE_DPAD_LEFT);
MAP(SDLK_KP_2, AKEYCODE_DPAD_DOWN);
MAP(SDLK_KP_8, AKEYCODE_DPAD_UP);
MAP(SDLK_KP_7, AKEYCODE_MOVE_HOME);
MAP(SDLK_KP_1, AKEYCODE_MOVE_END);
MAP(SDLK_KP_3, AKEYCODE_PAGE_DOWN);
MAP(SDLK_KP_9, AKEYCODE_PAGE_UP);
MAP(SDLK_KP_0, AKEYCODE_INSERT);
MAP(SDLK_KP_PERIOD, AKEYCODE_FORWARD_DEL);
}
}

// if ALT and META are not pressed, also handle letters and space
switch (from) {
MAP(SDLK_a, AKEYCODE_A);
Expand Down