Handle events on NumPad when NumLock is disabled

[jaafarbi]

Hello, I tried to fix the issue #1048.
I mapped the NumPad keys as follow when both SHIFT and NUM aren't set:

• SDLK_KP_6 --> AKEYCODE_DPAD_RIGHT
• SDLK_KP_4 --> AKEYCODE_DPAD_LEFT
• SDLK_KP_2 --> AKEYCODE_DPAD_DOWN
• SDLK_KP_8 --> AKEYCODE_DPAD_UP
• SDLK_KP_7 --> AKEYCODE_MOVE_HOME
• SDLK_KP_1 --> AKEYCODE_MOVE_END
• SDLK_KP_3 --> AKEYCODE_PAGE_DOWN
• SDLK_KP_9 --> AKEYCODE_PAGE_UP
• SDLK_KP_0 --> AKEYCODE_INSERT
• SDLK_KP_PERIOD --> AKEYCODE_FORWARD_DEL

[npes87184]

Hi,

Why the condition including not shift?

Thank you.

[npes87184]

I believe that there are some coding style issues.

[jaafarbi]

I did some modifications regarding the coding style issues. Can you tell me what was exactly the issue?

Thank you

[npes87184]

Great! From now, I only notice that we need a space after switch.

[jaafarbi]

Hi, I tried to mimic the behavior of the keyboard. If you disable the NumLock, and try the NumPad numbers with SHIFT, it'll work as the NumLock was enabled.

EDIT: At least, on Ubuntu system

[npes87184]

Hi, I tried to mimic the behavior of the keyboard. If you disable the NumLock, and try the NumPad numbers with SHIFT, it'll work as the NumLock was enabled.

EDIT: At least, on Ubuntu system

I try it on my windows 10 ver 1909, the shift + numpad when num lock off, it works like shift + arrow, insert, home, etc.

[jaafarbi]

Should we go for Windows behavior? or the Ubuntu's one?

Thanks

[npes87184]

Should we go for Windows behavior? or the Ubuntu's one?

Thanks

The behavior problem should contact @rom1v .
In my opinion, we can use different behavior in windows and ubuntu.

Thank you.

[rom1v]

Thank you for your contribution (and sorry for the delay).

I think checking SHIFT like you do produces the correct behavior: if shift is enabled, a text event will be generated, and managed as a text, so we must absolutely not send key events in that case.

IMO, the block should be moved few lines above so that it works even if --prefer-text is passed.

I squashed your commits, rebased on dev, and applied the changes I suggest: cd69eb4 (I also reordered the lines to sort by number, but it's just personal preference)

Please review and if it's ok I'll merge into dev.

[jaafarbi]

Thank you for your answer. Since it is one of my first contributions, yes everything is fine for me.

[rom1v]

it is one of my first contributions

Congrats 🎉

Merged in dev. It will be in the next release.