Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC/projections: Make example design consistent #3464

Merged
merged 8 commits into from
Sep 30, 2024

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Sep 28, 2024

Description of proposed changes

This PR updates the projection examples to use the same colors for land and water within in one category.
So far I have used this color combinations:
colors_projections

If we have agreed on the colors, we can use different ways to passe the colors (GMT name, RGB code, HEX codes).
There are also some changes to make the code consistent.

Preview:

Fixes #3458

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Sep 28, 2024
@yvonnefroehlich yvonnefroehlich self-assigned this Sep 28, 2024
@seisman seisman added this to the 0.14.0 milestone Sep 28, 2024
yvonnefroehlich and others added 2 commits September 28, 2024 17:51
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@yvonnefroehlich yvonnefroehlich changed the title WIP: DOC/projections: Make example design consistent DOC/projections: Make example design consistent Sep 29, 2024
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Sep 29, 2024
@seisman seisman merged commit 9ddd91e into main Sep 30, 2024
10 of 11 checks passed
@seisman seisman deleted the make-proj-design-consistent branch September 30, 2024 05:27
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC/projections: Consistent design of examples
2 participants