Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC/projections: Consistent design of examples #3458

Closed
yvonnefroehlich opened this issue Sep 26, 2024 · 5 comments · Fixed by #3464
Closed

DOC/projections: Consistent design of examples #3458

yvonnefroehlich opened this issue Sep 26, 2024 · 5 comments · Fixed by #3464
Labels
documentation Improvements or additions to documentation maintenance Boring but important stuff for the core devs
Milestone

Comments

@yvonnefroehlich
Copy link
Member

yvonnefroehlich commented Sep 26, 2024

While working on PR #3451 I was wondering whether we should use a consistent design for all projection examples, especially the identical colors for land and water masses. I feel generating all examples in the same design looks better and more professional.

Current version Suggested update 01 (one design for all examples) Suggested update 02 (one design per category)
projections_colored projections_gray projections_color_per_category
@yvonnefroehlich yvonnefroehlich added question Further information is requested documentation Improvements or additions to documentation maintenance Boring but important stuff for the core devs labels Sep 26, 2024
@yvonnefroehlich yvonnefroehlich added this to the 0.14.0 milestone Sep 26, 2024
@seisman
Copy link
Member

seisman commented Sep 26, 2024

In the GMT 4 cookbook (https://www.soest.hawaii.edu/gmt/gmt/html/GMT_Docs.html#x1-990006), most projection examples are in white and black/gray. I guess Paul and others updated these examples to make them more eye-catching and also demonstrate how to specify colors by different ways in GMT.

I prefer to keep these examples unchanged, but let's hear from other people's thoughts.

@yvonnefroehlich
Copy link
Member Author

Interesting (I started with GMT 5.x). Maybe having one color per category is a compromise here?

@seisman
Copy link
Member

seisman commented Sep 27, 2024

Maybe having one color per category is a compromise here?

Not bad.

@yvonnefroehlich
Copy link
Member Author

Ping at the other @GenericMappingTools/pygmt-maintainers for their thoughts🙂.

@weiji14
Copy link
Member

weiji14 commented Sep 28, 2024

Yep, I'm ok with one color per category too (but not that yellow-ish palette please).

@seisman seisman removed the question Further information is requested label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants