Add placeholder codes for wrapping GMT_IMAGE/GMT_CUBE #3181
Conversation
seisman
added
maintenance
| raise NotImplementedError(f"kind={kind} is not supported yet.") | ||
| dtype = {"dataset": _GMT_DATASET, "grid": _GMT_GRID}[kind] | ||
| dtype = { | ||
| "dataset": _GMT_DATASET, | ||
| "grid": _GMT_GRID, | ||
| "image": _GMT_IMAGE, | ||
| "cube": _GMT_CUBE, | ||
| }[kind] |
There was a problem hiding this comment.
If we merge this PR for PyGMT v0.12.0, then NotImplementedError won't be raised right?
There was a problem hiding this comment.
Yes, but since it's a low-level API function, I guess users won't call it anyway and we maintainers should know what we're doing.
There was a problem hiding this comment.
But kind='image' and kind='cube' is showing up in the API docs at https://pygmt-dev--3181.org.readthedocs.build/en/3181/api/generated/pygmt.clib.Session.virtualfile_out.html. Can we push this PR to v0.13.0? There's no real benefit to users in having this merged anyway without GMT_IMAGE/GMT_CUBE being wrapped right?
There was a problem hiding this comment.
Oh wait, that was the docs for virtualfile_out, I meant https://pygmt-dev--3181.org.readthedocs.build/en/3181/api/generated/pygmt.clib.Session.read_virtualfile.html
There was a problem hiding this comment.
I guess we can close this PR, since it's likely we will finish wrapping GMT_IMAGE first and then GMT_CUBE later, so we only need to deal with the conflicts in PR #3150.
I don't think we can finish wrapping
GMT_IMAGEandGMT_CUBEin the next few weeks, so it is better to push them to PyGMT v0.13.0.This PR cherry-pick codes used in wrapping
GMT_IMAGE/GMT_CUBE(#3150 and #3128) to minimize potential conflicts in #3150 and #3128.