Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap GMT's standard data type GMT_CUBE for cubes #3150

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 31, 2024

Similar to #3338, but for wrapping GMT_CUBE. In this PR, we focus on wrapping the GMT_CUBE structure and will implement the to_dataarray method in the future.

There are two known issues here:

  1. It seems we can't use lib.call_module("read", "@cube.nc out.nc -Tu") for cubes. The similar command works well for grids and images. It's likely an upstream bug.
  2. As shown in the doctest, the cube header information is correct, but the data still makes no sense yet. Maybe upstream bug or not.

Base automatically changed from gmtgrid/parser to main April 1, 2024 05:56
@seisman seisman force-pushed the datatypes/gmtcube branch from fe976e4 to 1c5df8c Compare April 1, 2024 06:00
@seisman seisman force-pushed the datatypes/gmtcube branch from 499c519 to b59efe0 Compare July 19, 2024 08:51
@seisman seisman added the feature Brand new feature label Jul 27, 2024
@seisman seisman removed this from the 0.14.0 milestone Sep 5, 2024
@seisman seisman self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants