Use uuid.uuid4 to generate unique names #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
commented
Jan 23, 2019
pygmt/helpers/tempfile.py
Outdated
| # Use the tempfile module to generate a unique name. | ||
| with NamedTemporaryFile(prefix="gmt-python-") as tmpfile: | ||
| return os.path.split(tmpfile.name)[-1] | ||
| return "gmt-python-" + uuid.uuid4().hex |
There was a problem hiding this comment.
I'm not sure how to deal with the prefix gmt-python. Possible ways:
- No prefix at all
- Change
gmt-python-topygmt- - Add arguments
prefixandsuffixtounique_name.
There was a problem hiding this comment.
I think we can remove that prefix. Not sure why I added it but it really doesn't make a difference.
leouieda
requested changes
Jan 23, 2019
pygmt/helpers/tempfile.py
Outdated
| # Use the tempfile module to generate a unique name. | ||
| with NamedTemporaryFile(prefix="gmt-python-") as tmpfile: | ||
| return os.path.split(tmpfile.name)[-1] | ||
| return "gmt-python-" + uuid.uuid4().hex |
There was a problem hiding this comment.
I think we can remove that prefix. Not sure why I added it but it really doesn't make a difference.
leouieda
approved these changes
Jan 24, 2019
|
The failure is because of #276. Will rerun the checks after that is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Use
uuid.uuid4().hexto generate unique names.Fixes #273
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.