Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the uuid package to generate figure names #273

Closed
leouieda opened this issue Jan 23, 2019 · 0 comments · Fixed by #274
Closed

Use the uuid package to generate figure names #273

leouieda opened this issue Jan 23, 2019 · 0 comments · Fixed by #274
Labels
feature request New feature wanted good first issue Good for newcomers help wanted Helping hands are appreciated

Comments

@leouieda
Copy link
Member

Description of the desired feature

GMT figure names need to be unique and are generated by the unique_name function in pygmt/helpers/tempfile.py. Currently, it uses tmpfile to generate a unique name but this isn't ideal and kind of a hack. A better way would be to use the builtin uuid.uuid4 function.
@leouieda leouieda added good first issue Good for newcomers help wanted Helping hands are appreciated feature request New feature wanted labels Jan 23, 2019
@seisman seisman mentioned this issue Jan 23, 2019
Merged
5 tasks
leouieda pushed a commit that referenced this issue Jan 24, 2019
@seisman @leouieda
Use uuid.uuid4 to generate unique names (#274)
63e8959 
Use `uuid.uuid4().hex` to generate unique names.

Fixes #273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature wanted good first issue Good for newcomers help wanted Helping hands are appreciated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use uuid.uuid4 to generate unique names GenericMappingTools/pygmt
1 participant
@leouieda