Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update draft release workflow #5174

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Update draft release workflow #5174

merged 3 commits into from
Apr 27, 2021

Conversation

maxrjones
Copy link
Member

Description of proposed changes

This PR includes three changes to the draft-release workflow:

  1. Replace "actions/upload-release-asset" with "softprops/action-gh-release".
  2. Use updated method for setting environment variables in GitHub worklows
  3. Separate win32 steps depending on whether it is a full release or release candidate

Fixes #5150

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@maxrjones maxrjones requested a review from seisman April 26, 2021 19:53
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test it, but it looks good.

@maxrjones maxrjones merged commit b146995 into master Apr 27, 2021
@maxrjones maxrjones deleted the update-draft-release branch April 27, 2021 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "actions/upload-release-asset" with "softprops/action-gh-release" in draft-release.yml
2 participants