Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "actions/upload-release-asset" with "softprops/action-gh-release" in draft-release.yml #5150

Closed
seisman opened this issue Apr 17, 2021 · 4 comments · Fixed by #5174
Closed
Assignees

Comments

@seisman
Copy link
Member

seisman commented Apr 17, 2021

The actions/upload-release-asset action used in the draft-release.yml workflow is no longer maintained, and softprops/action-gh-release is recommended.

We need to replace the old action with the recommended one.

@maxrjones
Copy link
Member

Does this need to happen before rc1? Do you to fix this issue? If you want, I can try submitting an update for the draft-release action.

@seisman
Copy link
Member Author

seisman commented Apr 18, 2021

Does this need to happen before rc1?

It's not necessary, but the rc1 release is a good opportunity to test the new action.

Feel free to work on it before or after rc1.

@maxrjones maxrjones self-assigned this Apr 19, 2021
@maxrjones
Copy link
Member

I think there will be an rc2, so we can test a solution then.

@maxrjones
Copy link
Member

Just an update that I am going to wait a bit before addressing this issue, in case a decision is made regarding this issue (GenericMappingTools/gmtserver-admin#83) first, which could impact the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants