Create DataWriter as a base class for JSONWriter #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Add HeaderDoc comments for JSONWriter and JSONWriterError.
Changes: - Revert to using CLUWritable protocol instead of JSONWriter for better flexibility.
Changes: - Rename JSONWriterError to DataWriterError. - Refactor DataWriterError to handle all possible errors for data writer classes. - Rename JSONWriterErrorTests to DataWriterErrorTests. - Refactor writer error tests.
Changes: - Add DataWriter class to encapsulate the details of writing data to a stream. - Refactor JSONWriter to be a subclass of DataWriter.
Changes: - Alphabetize error cases for DataWriterError.
|
Hey @Geek-1001, I was thinking about tackling Issue #13 next. Unless there is some item with an higher priority I should look into. Thanks! |
|
Hi @andrea-prearo
Yes, sure, feel free to fix #13 |
|
Thanks @Geek-1001! Your plan sounds good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #15 and the the additional feedback for PR #10.