Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create VideoWriter for writing video files #11

Open
andrea-prearo opened this issue Apr 26, 2017 · 2 comments
Open

Create VideoWriter for writing video files #11

andrea-prearo opened this issue Apr 26, 2017 · 2 comments

Comments

@andrea-prearo
Copy link
Contributor

Description

Right now, we are using CLUVideoWriter to write video content to file. We'd like to create a specific writer for video content (VideoWriter) to better encapsulate this functionality.

@Geek-1001
Copy link
Owner

Do you mean migrate CLUVideoWriter to Swift and create VideoWriter, right? 🙂
I think the encapsulation in CLUVideoWriter is fine (could be better but still).
We need to migrate it to Swift, that's for sure.

Let me take this one. I'll recreate VideoWriter in Swift and replace it wherever it needs to be replaced so we can continue with our migration further. And we'll discuss everything in a pull-request.
What do you think?

@andrea-prearo
Copy link
Contributor Author

Yes, this issue is about migrating CLUVideoWriter to Swift by creating a VideoWriter class. 👍

The note about the encapsulation is more of a reminder about looking for possible improvements. As we are migrating to Swift, there may be situations where we could improve on the original Objective C implementation/design by taking advantage of better abstractions only available with Swift. For instance, using Result<T, ErrorType> instead of the original NSError**, or storing an error as a public read-only property, could be one of those situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants