You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, we are using CLUVideoWriter to write video content to file. We'd like to create a specific writer for video content (VideoWriter) to better encapsulate this functionality.
The text was updated successfully, but these errors were encountered:
Do you mean migrate CLUVideoWriter to Swift and create VideoWriter, right? 🙂
I think the encapsulation in CLUVideoWriter is fine (could be better but still).
We need to migrate it to Swift, that's for sure.
Let me take this one. I'll recreate VideoWriter in Swift and replace it wherever it needs to be replaced so we can continue with our migration further. And we'll discuss everything in a pull-request.
What do you think?
Yes, this issue is about migrating CLUVideoWriter to Swift by creating a VideoWriter class. 👍
The note about the encapsulation is more of a reminder about looking for possible improvements. As we are migrating to Swift, there may be situations where we could improve on the original Objective C implementation/design by taking advantage of better abstractions only available with Swift. For instance, using Result<T, ErrorType> instead of the original NSError**, or storing an error as a public read-only property, could be one of those situations.
Description
Right now, we are using
CLUVideoWriter
to write video content to file. We'd like to create a specific writer for video content (VideoWriter
) to better encapsulate this functionality.The text was updated successfully, but these errors were encountered: