Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 for RSVP and RSVP Response blocks #959

Merged
merged 116 commits into from
Dec 31, 2024
Merged

Conversation

mauteri
Copy link
Contributor

@mauteri mauteri commented Nov 16, 2024

Description of the Change

This is a complete rewrite of the RSVP and RSVP Response blocks (called V2 for now). The custom blocks are now block just wrapping blocks with core and custom blocks in a template. Interactivity API is being added for functionality that the custom React Block used to provide. The intent of this is to keep all/most of the functionality the previous blocks provided, but allow additional flexibility around styling and configuring these blocks. Some new blocks are being introduced like the Modal block and RSVP Status block since those blocks do not exist in core. The idea is to use core blocks wherever it is possible and makes sense (same with block variations) and create custom blocks when such a thing feels unnatural or confusing.

This is a huge PR since there is a lot of functionality that is contingent on other functionality. I don't love that this PR is so huge, but I plan to draw the line with MVP functionality of these blocks before creating new PRs to further enhance the blocks as we test.

At the end of all this, these blocks will be replacing the RSVP and RSVP Response blocks.

Closes #691 #589 #696 #934 #573

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

what-the-diff bot commented Nov 16, 2024

PR Summary

  • Introduction of a new "Modal" block
    This PR includes a newly created "Modal" block which users can customize by choosing content and color. This block will allow users to introduce more interactive elements on their page.

  • Creation of "Modal" block script and edit component
    In addition to the "Modal" block, scripts and components are introduced to aid in editing and customizing this block.

  • New "RSVP V2" block
    This PR also introduces a new block called "RSVP V2". This block contains both initial and interacted labels, allowing for dynamic content to be displayed based on user interactions.

  • Editor component for "RSVP V2" block
    The PR also brings an editor component for the "RSVP V2" block, which lets users easily change the dynamic labels.

  • Support file for "RSVP V2" block interactivity
    Additional file views have been added to handle interactivity between users and the "RSVP V2" block.

  • Creation of Rsvp class
    A new server-side class labeled Rsvp has been created to manage the logic and render of the "RSVP V2" block, maintaining an efficient workflow.

  • Integration of WordPress block editor features
    Dependency files have been introduced to provide additional features to the WordPress block editor such as block arrangement, editing, and more.

  • New "Single Button Group" block
    A variation of the "RSVP" block is being introduced under this PR named as "Single Button Group" offering more visual choices to the users.

  • Additional assets and scripts for new blocks
    To effectively work with the newly introduced blocks, various new assets and scripts including styling files are added.

  • Introduction of test store for testing
    A new test store is included in the PR for testing purposes, ensuring the new blocks function correctly and align with desired parameters.

@mauteri mauteri changed the title Feature/rsvp block variation RSVP blocks V2 Dec 1, 2024
@mauteri mauteri marked this pull request as ready for review December 31, 2024 13:33
Copy link

Preview changes with Playground

You can preview the recent changes for PR#959 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@mauteri mauteri merged commit b3d6864 into develop Dec 31, 2024
18 checks passed
@mauteri mauteri deleted the feature/rsvp-block-variation branch December 31, 2024 13:37
const { getEntityRecords } = select(coreStore);

const users = getEntityRecords('root', 'user', {
per_page: -1,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauteri Can we use something other than -1 here to avoid potential performance issues?

Copy link
Collaborator

@jmarx jmarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lett a non blocking comment. It all looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEW interactive RSVP block
2 participants