Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink button styling and fix a11y issues #573

Open
mauteri opened this issue Feb 28, 2024 · 0 comments
Open

Rethink button styling and fix a11y issues #573

mauteri opened this issue Feb 28, 2024 · 0 comments
Assignees
Labels

Comments

@mauteri
Copy link
Contributor

mauteri commented Feb 28, 2024

Currently, buttons used for RSVP and the buttons in the RSVP modal rely on styling from the core Button block (uses the classes components-button-group, wp-block-buttons, and wp-block-button).

In this ticket, I'd like us to remove the usage of those classes and use our own styles that work with majority of themes (and using the primary colors set by the theme).

Also, currently we are using anchor tags for these buttons. This decision was made to prevent issues with odd button styling in themes that I was noticing when using the button block classes. Since we are moving away from those button block classes, let's use the button element instead of the a element, so markup is semantic and is no longer an a11y no-no.

Relevant links to read:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/button_role (aria with anchor tags)
https://equalizedigital.com/events/ (a11y experts)

@mauteri mauteri self-assigned this Feb 28, 2024
@mauteri mauteri converted this from a draft issue Feb 28, 2024
@mauteri mauteri moved this from Next Release to In Progress in GatherPress Project Mar 2, 2024
@mauteri mauteri moved this from In Progress to Next Release in GatherPress Project Mar 9, 2024
@mauteri mauteri removed their assignment Jun 13, 2024
@mauteri mauteri moved this from Next Release to Icebox in GatherPress Project Jun 14, 2024
@mauteri mauteri self-assigned this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Icebox
Development

No branches or pull requests

2 participants