Add caching of datetimes to improve performance. #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deshabhishek007 new PR that combines aspects of your PR to make fewer DB calls by utilizing the event object to store data in properties. Let me know what you think. Thx! |
jmarx
approved these changes
Jan 28, 2024
|
@mauteri Nice! |
…nt extra DB calls. Removed caching as transients will take over.
jmarx
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
PR #508 was reverted due to bug not invalidating cache on update. This PR replaces cache with transient API so DB calls aren't repeated.
Closes #507
How to test the Change
Functionality around datetime should remain same. Use Query Monitor to see no more repeated calls to
get_datetimemethod, which resulted in duplicated DB calls.Credits
Props @mauteri, @deshabhishek007
Checklist: