Fix for Issue #507: Optimize get_formatted_datetime Performance #508
Conversation
Transient time set to 12 Hours for now.
There was a problem hiding this comment.
Thanks for the PR, @deshabhishek007! Couple small clean ups and this will be good to merge. :-)
| @@ -399,6 +399,14 @@ protected function get_formatted_datetime( | |||
| string $which = 'start', | |||
| bool $local = true | |||
| ): string { | |||
|
|
|||
| $cache_key = 'formatted_datetime_' . md5($format . $which . ($local ? 'local' : 'gmt')); | |||
|
|
|||
There was a problem hiding this comment.
I would remove this line break and line up = also add more whitespace to meet WordPress standards.
$cache_key = 'formatted_datetime_' . md5( $format . $which . ( $local ? 'local' : 'gmt' ) );
$cached_date = get_transient( $cache_key );
|
|
||
| $cache_key = 'formatted_datetime_' . md5($format . $which . ($local ? 'local' : 'gmt')); | ||
|
|
||
| $cached_date = get_transient($cache_key); |
| $cache_key = 'formatted_datetime_' . md5($format . $which . ($local ? 'local' : 'gmt')); | ||
|
|
||
| $cached_date = get_transient($cache_key); | ||
| if ($cached_date !== false) { |
There was a problem hiding this comment.
Yoda notation and a bit more whitespace.
if ( false !== $cached_date ) {
| @@ -419,6 +427,7 @@ protected function get_formatted_datetime( | |||
| $date = wp_date( $format, $ts, $tz ); | |||
| } | |||
|
|
|||
| set_transient($cache_key, $date, 43200); | |||
There was a problem hiding this comment.
line break here before return and add white space
set_transient( $cache_key, $date, HOUR_IN_SECONDS * 12 );
return (string) $date;
- applied WPCS updates - transient time in easy to read format shared by Mike
|
Looks good, merging! Thanks! |
|
@deshabhishek007 Need to revert this change, it is caching and not changing the date when the date changes. We'll need to look at this deeper to ensure this makes fewer DB calls, but does not cache the date so it cannot be changed. |
|
@deshabhishek007 I reverted this code here. #516 Steps to reproduce bug I saw is to go to an event, change the date, view the event and the date is the previous date as it is still cached. We need a way to invalidate the cache on save so this doesn't happen. In next attempt, please include some unit tests to ensure this works after caching. Thanks! |
This PR provides a solution to the performance issue reported in Issue #507. It introduces caching to the get_formatted_datetime function, reducing database query load and improving efficiency.