Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from ansi-wl-pprint to the prettyprinter package. #931

Merged
merged 4 commits into from
Dec 4, 2020

Conversation

brianhuffman
Copy link
Contributor

This is a draft PR for testing purposes; it will only be ready to merge once all the relevant downstream packages have had their prettyprinter PRs merged and the submodule references fixed.

At the moment, this PR only updates the saw-core repo to use prettyprinter; the what4, crucible, macaw, and saw-core-coq repos should also be included before this PR is ready.

@brianhuffman brianhuffman marked this pull request as ready for review December 3, 2020 23:26
@brianhuffman
Copy link
Contributor Author

The prettyprinter PRs for what4, crucible, and macaw have all been merged, and I think this one is all ready to go (pending CI approval).

@brianhuffman brianhuffman requested review from atomb and kquick December 3, 2020 23:27
Copy link
Member

@kquick kquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the three comments, none of which is critical to merging this PR; aside from those this looks good!

src/SAWScript/AST.hs Outdated Show resolved Hide resolved
src/SAWScript/AST.hs Show resolved Hide resolved
src/SAWScript/JavaPretty.hs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants