-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert jvm-parser
to use prettyprinter
library
#951
Labels
tech debt
Issues that document or involve technical debt
Comments
Packages |
brianhuffman
pushed a commit
that referenced
this issue
Feb 2, 2021
brianhuffman
pushed a commit
that referenced
this issue
Feb 3, 2021
brianhuffman
pushed a commit
that referenced
this issue
Feb 3, 2021
brianhuffman
pushed a commit
that referenced
this issue
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With PR #931, most packages in the SAW ecosystem will have standardized on the modern
prettyprinter
library for pretty printing. Everything that was previously usingansi-wl-pprint
has been ported toprettyprinter
. However, there are still some submodules that use the oldText.PrettyPrint.HughesPJ
library (from packagepretty
) for pretty printing, includingjvm-parser
.Text.PrettyPrint.HughesPJ
is not so similar toprettyprinter
asansl-wl-pprint
is, so it will be a bit more work to convert. But when we do, we can avoid the "icky" conversions fromDoc
toString
to otherDoc
type that we see in modules likeSAWScript.JavaPretty
:saw-script/src/SAWScript/JavaPretty.hs
Line 52 in 14bab8f
saw-script/src/SAWScript/JavaPretty.hs
Line 71 in 14bab8f
The text was updated successfully, but these errors were encountered: