Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRSolver] Improved heterogenous interface, bug fixes for SHA512 example #1743

Merged
merged 13 commits into from
Sep 29, 2022

Conversation

m-yac
Copy link
Contributor

@m-yac m-yac commented Sep 23, 2022

I don't recommend reviewing this PR all together, since it is really the sum of a number of independent changes (sorry about that!). Each commit should be self-contained and have an accurate description, the main changes being:

and the only other non-trivial changes being:

@m-yac m-yac added the subsystem: MRSolver Issues related to the Mr. Solver monadic-recursive solver in Heapster label Sep 23, 2022
@m-yac m-yac requested a review from eddywestbrook September 23, 2022 18:26
Copy link
Contributor

@eddywestbrook eddywestbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this is a bit much to review all at once, but as you said I have reviewed the major pieces of this with you as you wrote them, so I'm pretty confident about these changes. Plus, MR Solver still passes all of our CI tests, which is also a good sign.

@eddywestbrook eddywestbrook added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Sep 29, 2022
@mergify mergify bot merged commit 1ea10d0 into master Sep 29, 2022
@mergify mergify bot deleted the mr-solver-split branch September 29, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: MRSolver Issues related to the Mr. Solver monadic-recursive solver in Heapster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants