Heapster disable debug output #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 31, 2021 12:27
…made the translation of bitvector permissions to just be bitvectors
…all of the Heapster code so that no debug output is printed unless the Heapster debug level is set to at least 1
m-yac
approved these changes
Sep 3, 2021
| @@ -3806,16 +3806,18 @@ debugPrettyPermCtx prxs (ptranss :>: ptrans) = | |||
| translateApply :: String -> OpenTerm -> Mb ctx (DistPerms ps) -> | |||
| ImpTransM ext blocks tops ret ps ctx OpenTerm | |||
| translateApply nm f perms = | |||
| do expr_ctx <- itiExprCtx <$> ask | |||
| do assertPermStackEqM nm perms | |||
There was a problem hiding this comment.
This addition seems unrelated to the purpose of the PR, just wanted to make sure it was intentional.
Comment on lines
+3815
to
+3820
| {- | ||
| trace ("translateApply for " ++ nm ++ " with perm arguments:\n" ++ | ||
| -- renderDoc (list $ debugPrettyPermCtx (mbToProxy perms) i_args) | ||
| -- permPrettyString emptyPPInfo (permTransCtxPerms (mbToProxy perms) i_args) | ||
| permPrettyString emptyPPInfo perms | ||
| ) $ | ||
| ) $ -} |
There was a problem hiding this comment.
Why was this removed? Just curious.
I didn't make comments for them, but I have the same question for all the "X starting..." and "X finished..." traces in this file, the trace in rsConvertFun, and the trace in bvSLt. Is the answer for all of them just that you haven't found them useful so far?
eddywestbrook
added
subsystem: heapster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the notion of a Heapster debug level that controls whether debug information is sent to the output, and sets it to 0 by default, so that debug information is not printed by default. It also adds the command
heapster_set_debug_levelthat allows the user to set the debug level, to enable debug output.