Heapster: remove generated coq files #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 23, 2021 13:45
… to match a given recognizer; this ensures that globals with non-normalized types (e.g., with types that are computed) which evaluate to function, pair, or record types can still be eliminated via applications or the appropriate projections, respectively
… named XXX_gen.v; also removed all generated Coq files from the repo, so they can be re-generated by CI
eddywestbrook
added
the
subsystem: heapster
added 11 commits
August 23, 2021 15:36
…o I made one generic rule for it
…isInc/saw-script into heapster-remove-generated-coq-files
m-yac
approved these changes
Aug 24, 2021
| shell: bash | ||
| run: | | ||
| chmod +x dist/bin/* | ||
| echo $GITHUB_WORKSPACE/dist/bin >> $GITHUB_PATH |
There was a problem hiding this comment.
Is this $GITHUB_PATH variable used? Seems like you use $GITHUB_WORKSPACE/dist/bin directly below.
There was a problem hiding this comment.
Yeah, there is some duplication of concerns here, because I was trying to get it to work. I'll fix some of that now...
RyanGlScott
reviewed
Aug 24, 2021
.github/workflows/ci.yml
Outdated
| @@ -193,6 +193,15 @@ jobs: | |||
| name: "${{ runner.os }}-bins" | |||
| path: dist/bin | |||
|
|
|||
| - name: Update PATH to include sAW | |||
There was a problem hiding this comment.
Suggested change
| - name: Update PATH to include sAW | |
| - name: Update PATH to include SAW |
There was a problem hiding this comment.
Doh! Thanks for the catch!
…CI to set the PATH correctly, rather than using a github-specific path to SAW
eddywestbrook
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes all the generated Coq files from the repo so that they get regenerated as part of CI. It also renames all the generated Coq files to
XXX_gen.v, in order to make it easier to add them to the.gitignorefile.NOTE: this PR depends on #1426, so should not be merged until that one is.