[Heapster] Simplify translation of exists x.eq(y) perms
#1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-yac: it looks like some of the CI fails; specifically, it looks like |
eddywestbrook
approved these changes
Aug 19, 2021
| @@ -39,11 +39,11 @@ heapster_define_perm env "boolean" " " "llvmptr 1" "exists x:bv 1.eq(llvmword(x) | |||
| // memcpy i64 | |||
| // heapster_assume_fun env "llvm.memcpy.p0i8.p0i8.i64" "(X:perm(llvmptr 64), Y:perm(llvmptr 64)).arg0:(exists x:bv 1.X), arg1:(exists x:bv 1.Y), arg2:true, arg3:true -o arg0:(exists x:bv 1.Y), arg1:(exists x:bv 1.Y)" "\\ (X:sort 0) (Y:sort 0) (_:SigBV1 X) (y:SigBV1 Y) -> returnM (SigBV1 Y * (SigBV1 Y * #())) (y, (y, ()))"; | |||
|
|
|||
| // heapster_assume_fun env "llvm.memcpy.p0i8.p0i8.i64" "(len:bv 64).arg0:byte_array<W,len>, arg1:byte_array<W,len>, arg2:eq(llvmword(len)), arg3:true -o arg0:byte_array<W,len>, arg1:byte_array<W,len>" "\\ (len:Vec 64 Bool) (x y:BVVec 64 len BV8) -> returnM (BVVec 64 len BV8 * (BVVec 64 len BV8 * #())) (y, (y, ()))"; | |||
| // heapster_assume_fun env "llvm.memcpy.p0i8.p0i8.i64" "(len:bv 64).arg0:byte_array<W,len>, arg1:byte_array<W,len>, arg2:eq(llvmword(len)), arg3:true -o arg0:byte_array<W,len>, arg1:byte_array<W,len>" "\\ (len:Vec 64 Bool) (x y:BVVec 64 len (Vec 8 Bool)) -> returnM (BVVec 64 len (Vec 8 Bool) * (BVVec 64 len (Vec 8 Bool) * #())) (y, (y, ()))"; | |||
There was a problem hiding this comment.
Instead of changing these lines, maybe it would make more sense to change the definition of BV8 to be the new bitvector type without the dependent pair?
There was a problem hiding this comment.
Oh, I see, you just got rid of BV8 and friends. That makes sense too; you can ignore my comment if you like.
eddywestbrook
added
the
PR: ready to merge
m-yac
added
the
subsystem: heapster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the translation of a permission of the form
exists x.eq(y)is now just the translation ofx, instead of a sigma type whose first projection is the translation ofxand whose second projection isunit. All the SAW scripts and Coq proof scripts in theheapster-saw/examplesdirectory have been updated accordingly.NB: This PR adds back
arrays_proofs.vto the_CoqProjecteven though the proof ofno_errors_sum_2dis still broken - see #1421.