This repository has been archived by the owner on Jun 9, 2021. It is now read-only.
Switch Lambda and Pi constructors to use Text instead of String. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch will require some small changes to the |
|
While there are still uses of |
robdockins
approved these changes
Jan 19, 2021
added 3 commits
January 19, 2021 06:31
We introduce a type synonym `LocalName = Text` for this purpose. This is a step toward removing all uses of `String` in saw-core (#44).
brianhuffman
force-pushed
the
text-lambda
branch
from
8034ecb to
eadbd70
Compare
brianhuffman
pushed a commit
to GaloisInc/saw-core-coq
that referenced
this pull request
Jan 19, 2021
This switched lambda and pi binders in the saw-core AST from String to Text (introducing a new type synonym LocalName).
brianhuffman
pushed a commit
to GaloisInc/crucible
that referenced
this pull request
Jan 19, 2021
Some occurrences of `String` in the saw-core term AST have changed to `Text`.
brianhuffman
pushed a commit
to GaloisInc/crucible
that referenced
this pull request
Jan 19, 2021
Update saw-core submodule and adapt to GaloisInc/saw-core#119.
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 19, 2021
The saw-core term AST has changed some uses of `String` to `Text`.
brianhuffman
pushed a commit
to GaloisInc/saw-core-coq
that referenced
this pull request
Jan 19, 2021
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 19, 2021
The saw-core term AST has changed some uses of `String` to `Text`.
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 20, 2021
Update submodules and adapt to GaloisInc/saw-core#119.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce a type synonym
LocalName = Textfor this purpose.This is a step toward removing all uses of
Stringin saw-core (#44).See also #111.