Skip to content
This repository has been archived by the owner on Jun 9, 2021. It is now read-only.

Avoid using type String in saw-core term representation #44

Closed
brianhuffman opened this issue Nov 16, 2019 · 0 comments · Fixed by #119
Closed

Avoid using type String in saw-core term representation #44

brianhuffman opened this issue Nov 16, 2019 · 0 comments · Fixed by #119
Labels
tech debt

Comments

@brianhuffman
Copy link
Contributor

Type String comes with unwanted laziness and inefficiencies. We should universally use Text instead for all variable names and other identifiers inside saw-core terms.
brianhuffman pushed a commit that referenced this issue Jan 17, 2021
Switch Lambda and Pi constructors to use Text instead of String.
333c2a0 
We introduce a type synonym `LocalName = Text` for this purpose.

This is a step toward removing all uses of `String` in saw-core
(#44).
@brianhuffman brianhuffman mentioned this issue Jan 17, 2021
Merged
@brianhuffman brianhuffman linked a pull request Jan 18, 2021 that will close this issue
Switch Lambda and Pi constructors to use Text instead of String. #119
Merged
brianhuffman pushed a commit that referenced this issue Jan 19, 2021
Switch Lambda and Pi constructors to use Text instead of String.
9b3dc10 
We introduce a type synonym `LocalName = Text` for this purpose.

This is a step toward removing all uses of `String` in saw-core
(#44).
@brianhuffman brianhuffman mentioned this issue Jan 19, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch Lambda and Pi constructors to use Text instead of String. GaloisInc/saw-core
1 participant
@brianhuffman